cleaned up the song play file... switched over to use of debug_event function

1 files changed, 139 insertions, 156 deletions

diff --git a/play/index.php b/play/index.php
index cc230bc2..fded0525 100644
--- a/play/index.php
+++ b/play/index.php
@@ -33,9 +33,15 @@ require_once(conf('prefix') . '/modules/horde/Browser.php');
 
 
 /* These parameters had better come in on the url. */
-$uid = scrub_out($_REQUEST['uid']);
-$song_id = scrub_out($_REQUEST['song']);
-$sid = scrub_out($_REQUEST['sid']);
+$uid 		= scrub_in($_REQUEST['uid']);
+$song_id 	= scrub_in($_REQUEST['song']);
+$sid 		= scrub_in($_REQUEST['sid']);
+
+/* First things first, if we don't have a uid stop here */
+if (!isset($uid)) { 
+	debug_event('no_song',"Error: No Song UID Specified, nothing to play",'2');
+	exit; 
+}
 
 /* Misc Housework */
 $dbh = dbh();
@@ -48,6 +54,7 @@ if (conf('xml_rpc')) {
 if (conf('require_session') OR $xml_rpc) { 
 	if(!session_exists($sid,$xml_rpc)) {	
     		die(_("Session Expired: please log in again at") . " " . conf('web_path') . "/login.php");
+		debug_event('session_expired',"Streaming Access Denied: " . $GLOBALS['user']->username . "'s session has expired",'4');
 	}
 
 	// Now that we've confirmed the session is valid
@@ -56,10 +63,8 @@ if (conf('require_session') OR $xml_rpc) {
 }
 
 /* If we are in demo mode.. die here */
-if (conf('demo_mode') || (!$user->has_access('25') && !$xml_rpc) ) {
-	if (conf('debug')) { 
-		log_event($user->username,' access_denied ', "Streaming Access Denied, " . conf('demo_mode') . "is the value of demo_mode. Current user level is $user->access");
-	}
+if (conf('demo_mode') || (!$GLOBALS['user']->has_access('25') && !$xml_rpc) ) {
+	debug_event('access_denied',"Streaming Access Denied:" .conf('demo_mode') . "is the value of demo_mode. Current user level is " . $GLOBALS['user']->access,'3');
 	access_denied();
 }
 
@@ -68,66 +73,53 @@ if (conf('demo_mode') || (!$user->has_access('25') && !$xml_rpc) ) {
    that they have enough access to play this mojo
 */
 if (conf('access_control')) { 
-
 	$access = new Access(0);
 	if (!$access->check("25", $_SERVER['REMOTE_ADDR'])) { 
-		if (conf('debug')) { 
-			log_event($user->username,' access_denied ', "Streaming Access Denied, " . $_SERVER['REMOTE_ADDR'] . " does not have stream level access");
-		}
+		debug_event('access_denied', "Streaming Access Denied: " . $_SERVER['REMOTE_ADDR'] . " does not have stream level access",'3');
 		access_denied();
 	}
-
 } // access_control is enabled
 
 
-// require a uid and valid song
-if ( isset( $uid ) ) {
-	$song = new Song($song_id);
-	$song->format_song();
-	$catalog = new Catalog($song->catalog);
+$song = new Song($song_id);
+$song->format_song();
+$catalog = new Catalog($song->catalog);
 
-	// Create the user object if possible
+/* If the song is disabled */
+if (!make_bool($song->enabled)) { 
+	debug_event('song_disabled',"Error: $song->file is currently disabled, song skipped",'5');
+	exit;
+}
 
-	if (!$song->file OR ( !is_readable($song->file) AND $catalog->catalog_type != 'remote' ) ) { 
-		if (conf('debug')) { 
-			log_event($user->username,' file_not_found ',"Error song ($song->title) does not have a valid filename specified");
-		}
-		echo "Error: No Song"; 
-		exit; 
-	}
-	if ($song->status == '0') { 
-		if (conf('debug')) { 
-			log_event($user->username,' song_disabled ',"Error: $song->file is currently disabled, song skipped");
-		}
-		exit;
-	}
-	if ($user->disabled == '1') {
-		if (conf('debug')) { 
-			log_event($user->username,' user_disabled ',"Error $user->username is currently disabled, stream access denied");
-		}
-		echo "Error: User Disabled"; 
-		exit; 
-	}
-	if ( conf('use_auth') AND !$user->username AND !$user->is_xmlrpc() ) {
-		if (conf('debug')) { 
-			log_event($user->username,' user_not_found ',"Error $user->username not found, stream access denied");
-		}
-		echo "Error: No User Found"; 
-		exit; 
-	}
+/* If the user has been disabled (true value) */
+if (make_bool($GLOBALS['user']->disabled)) {
+	debug_event('user_disabled',"Error $user->username is currently disabled, stream access denied",'3');
+	echo "Error: User Disabled"; 
+	exit; 
+}
 
+/* If we don't have a file, or the file is not readable */
+if (!$song->file OR ( !is_readable($song->file) AND $catalog->catalog_type != 'remote' ) ) { 
+	debug_event('file_not_found',"Error song ($song->title) does not have a valid filename specified",'2');
+	echo "Error: Invalid Song Specified, file not found or file unreadable"; 
+	exit; 
 }
-else {
-	if (conf('debug')) { 
-		log_event("Unknown", ' user_not_found ',"Error no UID passed with URL, stream access denied");
-	}
-	echo "Error: No UID specified";
-	exit;
+	
+/* If we're using auth and we can't find a username for this user */
+if ( conf('use_auth') AND !$GLOBALS['user']->username AND !$GLOBALS['user']->is_xmlrpc() ) {
+	debug_event('user_not_found',"Error $user->username not found, stream access denied",'3');
+	echo "Error: No User Found"; 
+	exit; 
 }
 
+/* Create the catalog object so we know a little more about it */
 $catalog = new Catalog($song->catalog);
 
-if ( $catalog->catalog_type == 'remote' ) {
+/* Update the users last seen information */
+$GLOBALS['user']->update_last_seen();
+
+/* Check to see if this is a 'remote' catalog */
+if ($catalog->catalog_type == 'remote') {
 	// redirect to the remote host's play path
 	/* Break Up the Web Path */
 	preg_match("/http:\/\/([^\/]+)\/*(.*)/", conf('web_path'), $match);
@@ -136,128 +128,119 @@ if ( $catalog->catalog_type == 'remote' ) {
 	
 	$extra_info = "&xml_rpc=1&xml_path=$path&xml_server=$server&xml_port=80&sid=$sid";
 	header("Location: " . $song->file . $extra_info);
-	if (conf('debug')) { log_event($user->username,' xmlrpc-stream ',"Start XML-RPC Stream - " . $song->file . $extra_info); }
-}
-
-
-else {
+	debug_event('xmlrpc-stream',"Start XML-RPC Stream - " . $song->file . $extra_info,'5');
+	exit;
+} // end if remote catalog
 
-	// Update the users last seen
-	$user->update_last_seen();
 
-	/* Run Garbage Collection on Now Playing */
-	gc_now_playing();
+/* Run Garbage Collection on Now Playing */
+gc_now_playing();
 
-	// If we are running in Legalize mode, don't play songs already playing
-	if (conf('lock_songs')) {
-		if (!check_lock_songs($song->id)) { exit(); }
-	}
+// If we are running in Legalize mode, don't play songs already playing
+if (conf('lock_songs')) {
+	if (!check_lock_songs($song->id)) { exit(); }
+}
 
-	// Put this song in the now_playing table
-	$lastid = insert_now_playing($song->id,$uid,$song->time);
-
-	// make fread binary safe
-	set_magic_quotes_runtime(0);
-
-	// don't abort the script if user skips this song because we need to update now_playing
-	ignore_user_abort(TRUE);
-
-	/* Format the Song Name */
-	if (conf('stream_name_format')) {
-		$song_name = conf('stream_name_format');
-		$song_name = str_replace("%basename",basename($song->file),$song_name);
-		$song_name = str_replace("%filename",$song->file,$song_name);
-		$song_name = str_replace("%type",$song->type,$song_name);
-		$song_name = str_replace("%catalog",$catalog->name,$song_name);
-		$song_name = str_replace("%A",$song->f_album_full,$song_name); // this and next could be truncated version
-		$song_name = str_replace("%a",$song->f_artist_full,$song_name);
-		$song_name = str_replace("%C",$catalog->path,$song_name);
-		$song_name = str_replace("%c",$song->comment,$song_name);
-		$song_name = str_replace("%g",$song->f_genre,$song_name);
-		$song_name = str_replace("%T",$song->track,$song_name);
-		$song_name = str_replace("%t",$song->title,$song_name);
-		$song_name = str_replace("%y",$song->year,$song_name);
-	} 
-	else {
-		$song_name = $song->f_artist_full . " - " . $song->title . "." . $song->type;
-	}
+// Put this song in the now_playing table
+$lastid = insert_now_playing($song->id,$uid,$song->time);
+
+// make fread binary safe
+set_magic_quotes_runtime(0);
+
+// don't abort the script if user skips this song because we need to update now_playing
+ignore_user_abort(TRUE);
+
+/* Format the Song Name */
+if (conf('stream_name_format')) {
+	$song_name = conf('stream_name_format');
+	$song_name = str_replace("%basename",basename($song->file),$song_name);
+	$song_name = str_replace("%filename",$song->file,$song_name);
+	$song_name = str_replace("%type",$song->type,$song_name);
+	$song_name = str_replace("%catalog",$catalog->name,$song_name);
+	$song_name = str_replace("%A",$song->f_album_full,$song_name); // this and next could be truncated version
+	$song_name = str_replace("%a",$song->f_artist_full,$song_name);
+	$song_name = str_replace("%C",$catalog->path,$song_name);
+	$song_name = str_replace("%c",$song->comment,$song_name);
+	$song_name = str_replace("%g",$song->f_genre,$song_name);
+	$song_name = str_replace("%T",$song->track,$song_name);
+	$song_name = str_replace("%t",$song->title,$song_name);
+	$song_name = str_replace("%y",$song->year,$song_name);
+} 
+else {
+	$song_name = $song->f_artist_full . " - " . $song->title . "." . $song->type;
+}
 
 	
 
-	// Send file, possible at a byte offset
-	$fp = @fopen($song->file, 'r');
+// Send file, possible at a byte offset
+$fp = @fopen($song->file, 'r');
 
-	if (!is_resource($fp)) { 
-		if (conf('debug')) { 
-			log_event($user->username,' file_read_error ',"Error: Unable to open $song->file for reading");
-		}
-		cleanup_and_exit($lastid);
-	}
+if (!is_resource($fp)) { 
+	debug_event('file_read_error',"Error: Unable to open $song->file for reading",'2');
+	cleanup_and_exit($lastid);
+}
 
-	$startArray = sscanf( $_SERVER[ "HTTP_RANGE" ], "bytes=%d-" );
-	$start = $startArray[0];
+$startArray = sscanf( $_SERVER[ "HTTP_RANGE" ], "bytes=%d-" );
+$start = $startArray[0];
 
-	// Generate browser class for sending headers
-	$browser = new Browser();
-	header("Accept-Ranges: bytes" );
+// Generate browser class for sending headers
+$browser = new Browser();
+header("Accept-Ranges: bytes" );
 
-	// Prevent the script from timing out
-	set_time_limit(0);			
+// Prevent the script from timing out
+set_time_limit(0);			
 	
-	if ($user->prefs['play_type'] == 'downsample' || !$song->native_stream()) { 
+if ($GLOBALS['user']->prefs['play_type'] == 'downsample' || !$song->native_stream()) { 
+	$results = start_downsample($song,$lastid,$song_name);
+	$fp = $results['handle'];
+	$song->size = $results['size'];
 	
-		$results = start_downsample($song,$lastid,$song_name);
+} // end if downsampling
+
+elseif ($start) {
+	$browser->downloadHeaders($song_name, $song->mime, false, $song->size);
+	fseek( $fp, $start );
+	$range = $start ."-". ($song->size-1) . "/" . $song->size;
+	header("HTTP/1.1 206 Partial Content");
+	header("Content-Range: bytes=$range");
+	header("Content-Length: ".($song->size-$start));
+}
 
-		$fp = $results['handle'];
-		$song->size = $results['size'];
+/* Last but not least pump em out */
+else {
+	header("Content-Length: $song->size");
+	$browser->downloadHeaders($song_name, $song->mime, false, $song->size);
+}
+	
 
-	} // end if downsampling
+/* Let's force them to actually play a portion of the song before 
+ * we count it in the statistics
+ * @author SH
+ */
+$bytesStreamed  = 0;
+$minBytesStreamed = $song->size / 2;
+while (!feof($fp) && (connection_status() == 0)) {
+	$buf = fread($fp, 8192);
+        print($buf);
+        $bytesStreamed += strlen($buf);
+}
 
-	elseif ($start) {
-		$browser->downloadHeaders($song_name, $song->mime, false, $song->size);
-		fseek( $fp, $start );
-		$range = $start ."-". ($song->size-1) . "/" . $song->size;
-		header("HTTP/1.1 206 Partial Content");
-		header("Content-Range: bytes=$range");
-		header("Content-Length: ".($song->size-$start));
-	}
-	/* Last but not least pump em out */
-	else {
-		header("Content-Length: $song->size");
-		$browser->downloadHeaders($song_name, $song->mime, false, $song->size);
-	}
-	
+if ($bytesStreamed > $minBytesStreamed) {
+        $user->update_stats($song_id);
+} 
 
-	/* Let's force them to actually play a portion of the song before 
-	 * we count it in the statistics
-	 * @author SH
-	 */
-       	$bytesStreamed  = 0;
-        $minBytesStreamed = $song->size / 2;
-        while (!feof($fp) && (connection_status() == 0)) {
-                $buf = fread($fp, 8192);
-                print($buf);
-                $bytesStreamed += strlen($buf);
-        }
-
-        if ($bytesStreamed > $minBytesStreamed) {
-                $user->update_stats($song_id);
-        } 
-
-	/* Set the Song as Played if it isn't already */
-	$song->set_played();
-
-	/* Delete the Now Playing Entry */
-	delete_now_playing($lastid);
-
-	/* Clean up any open ends */
-	if ($user->prefs['play_type'] == 'downsample' || !$song->native_stream()) { 
-		@pclose($fp);
-	} 
-	else { 
-		@fclose($fp);
-	}
+/* Set the Song as Played if it isn't already */
+$song->set_played();
+
+/* Delete the Now Playing Entry */
+delete_now_playing($lastid);
 
+/* Clean up any open ends */
+if ($GLOBALS['user']->prefs['play_type'] == 'downsample' || !$song->native_stream()) { 
+	@pclose($fp);
+} 
+else { 
+	@fclose($fp);
 }
 
 ?>