summaryrefslogtreecommitdiffstats
path: root/lib/class/vainfo.class.php
diff options
context:
space:
mode:
authormomo-i <webmaster@momo-i.org>2011-02-04 10:18:08 +0900
committermomo-i <webmaster@momo-i.org>2011-02-04 10:18:08 +0900
commit115500a3e8e945ce3a09846f107d36460f08f01c (patch)
treebff890903394565c86d2858aebf92c7ff977365e /lib/class/vainfo.class.php
parent17bba7eedd0a54085da5c73767b3b27c3bca3010 (diff)
downloadampache-115500a3e8e945ce3a09846f107d36460f08f01c.tar.gz
ampache-115500a3e8e945ce3a09846f107d36460f08f01c.tar.bz2
ampache-115500a3e8e945ce3a09846f107d36460f08f01c.zip
added @todo id3tag broken
http://ampache.org/bugs/task/158 this is my task.
Diffstat (limited to 'lib/class/vainfo.class.php')
-rw-r--r--lib/class/vainfo.class.php18
1 files changed, 18 insertions, 0 deletions
diff --git a/lib/class/vainfo.class.php b/lib/class/vainfo.class.php
index bd3b6d31..7726cbe4 100644
--- a/lib/class/vainfo.class.php
+++ b/lib/class/vainfo.class.php
@@ -152,6 +152,8 @@ class vainfo {
* This function just sets up the class, it doesn't
* actually pull the information
*
+ * @todo Multibyte encoding break again...
+ * need to use id3v2 and to convert encoding
* @param string $file filename
* @param string $encoding Default encode character set
* @param string $encoding_id3v1 Default id3v1 encode character set
@@ -1038,9 +1040,13 @@ class vainfo {
/**
* _parse_filename
+ *
* This function uses the passed file and dir patterns
* To pull out extra tag information and populate it into
* its own array
+ *
+ * @param string $filename Filename that want to parse
+ * @return array Parsed results
*/
private function _parse_filename($filename) {
@@ -1083,8 +1089,12 @@ class vainfo {
/**
* _id3v2_tag_to_frame
+ *
* This translates the tag name to a frame, if there a many it returns the first
* one if finds that exists in the raw
+ *
+ * @param string $tag_name Tag name
+ * @return mixed If found id3v2 frame, return frame. If not found, return false.
*/
private function _id3v2_tag_to_frame($tag_name) {
@@ -1109,11 +1119,16 @@ class vainfo {
/**
* _clean_tag
+ *
* This function cleans up the tag that it's passed using Iconv
* if we've got it. It also takes an optional encoding param
* for the cases where we know what the tags source encoding
* is, and or if it's different then the encoding recorded
* in the file
+ *
+ * @param string $tag Encoding string
+ * @param string $encoding Encode charset
+ * @return string Return encoded string
*/
private function _clean_tag($tag, $encoding = null) {
@@ -1140,7 +1155,10 @@ class vainfo {
/**
* set_broken
+ *
* This fills all tag types with Unknown (Broken)
+ *
+ * @return array Return broken title, album, artist
*/
public function set_broken() {