summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Use the correct operator for 'before date' rulesthinca2013-05-302-1/+3
|
* Register session_write_close shutdown functionPaul Arthur2013-05-302-0/+5
| | | | | | | | | | | | | | | | http://php.net/manual/en/function.session-set-save-handler.php: When using objects as session save handlers, it is important to register the shutdown function with PHP to avoid unexpected side-effects from the way PHP internally destroys objects on shutdown and may prevent the write and close from being called. Typically you should register 'session_write_close' using the register_shutdown_function() function. We're not using objects as session save handlers, but some people (notably, Synology users) seem to be encountering a similar issue related to the timing of object destruction. Closing the session earlier in the shutdown process is a perfectly sane thing to do, so let's do it.
* Clean up the logic in install_insert_dbPaul Arthur2013-05-281-18/+15
| | | | Check the things in an order that makes sense and minimise duplication.
* CLI installation: allow skipping DB user creationPaul Arthur2013-05-281-1/+1
|
* Argh.Paul Arthur2013-05-271-1/+3
| | | | | Maybe if there are multiple examples for transcode_cmd people will stop and think about what they're doing.
* Change Dba::error() and audit its callersPaul Arthur2013-05-273-13/+15
| | | | | Will hopefully return more useful information during installation, which is the only place it's actually used and useful.
* Cosmetics: remove tabsPaul Arthur2013-05-271-3/+3
|
* install: Fix GRANT for non-localhost serversPaul Arthur2013-05-271-5/+5
| | | | | | | | | If we're not connecting locally, tell MySQL to allow our new user to connect from any host. Previously we restricted them to connecting from the database host, which is clearly wrong. It would be slightly better to properly restrict it to the Ampache host, but let's not overcomplicate the install and confuse the users.
* install: Add support for MySQL socketsPaul Arthur2013-05-272-3/+8
| | | | | If we're using a socket, grant privileges to user@localhost, not user@socketname.
* Dba: Add support for MySQL socketsrandomessence2013-05-271-1/+6
|
* Unify debugging output to a single filePaul Arthur2013-05-272-26/+26
| | | | | | Splitting some things off to ampache-catalog doesn't really make sense to me and makes it harder to see the entire process during catalog operations.
* Set the memory_limit to at least 32MPaul Arthur2013-05-152-2/+5
| | | | '32' != '32M'
* Don't reset the PHP memory_limit when it's -1Paul Arthur2013-05-151-1/+6
| | | | | This function is never supposed to lower the limit, and -1 is a flag value for no limit.
* Clean up Song->_get_info() and constructorPaul Arthur2013-05-131-21/+21
| | | | Return false and unset the id if the song isn't in the database.
* Increase the default memory limit to 32Paul Arthur2013-05-131-2/+2
| | | | This matches what the config files claims is the default.
* Fix Rating::gc()Paul Arthur2013-05-132-1/+3
| | | | | | The join was incorrect, sometimes resulting in loss of ratings. Fixes GH #22
* Make Catalog::count_songs use the correct variablePaul Arthur2013-05-132-1/+2
| | | | Fixes GH#23
* Increase the field size in the ACL entry formPaul Arthur2013-05-132-2/+4
| | | | | It wasn't large enough to enter IPv6 addresses. Fixes GH #24
* Add a working check for database existencePaul Arthur2013-05-132-2/+3
| | | | Fixes GH #21
* More cleanup of install, add DB port optionPaul Arthur2013-05-136-117/+116
|
* Clean up the install code a bitPaul Arthur2013-05-136-174/+48
| | | | | Remove lang/charset copypasta, unnecessary setting of $prefix, unnecessary constants.
* Fix 'foo all catalogs' via the web interfacePaul Arthur2013-05-132-10/+11
| | | | | | | Evidently Catalog::get_catalog_ids() wasn't quite as unused as I thought it was. Fixes GH #18
* Add support for nonstandard MySQL portsPaul Arthur2013-05-133-2/+14
|
* Bump getID3 versionPaul Arthur2013-05-1315-352/+550
|
* Stream::start_transcode: Fix typo in queryToilal2013-05-061-1/+1
|
* docs/INSTALL doesn't exist any morePaul Arthur2013-04-291-1/+1
|
* Update the stream_playlist table to use MyISAMPaul Arthur2013-04-292-1/+15
| | | | | | | | | | | | InnoDB's performance is unacceptable out of the box, and there's no clean way to batch these insertions into transactions, and stuff. Benchmarks for 1000 inserts: InnoDB: 54.826 MyISAM: 0.091 InnoDB transaction: 0.159 Fixes GH #14
* Correct debug output for Stream_Playlist addsPaul Arthur2013-04-291-1/+1
|
* Clean up Random::play_url()Paul Arthur2013-04-233-4/+6
| | | | | | | | | Include the correct type parameter in the URL and rename the random type parameter to random_type. Remove unused parameters from the function call. Should fix issue #11
* Cosmetics: html5_player.phpPaul Arthur2013-04-152-8/+5
| | | | Correct vim modeline. Remove useless switch.
* Finalise 3.6-alpha53.6-alpha5Paul Arthur2013-04-152-3/+3
|
* Update recommended version in READMEPaul Arthur2013-04-131-3/+1
|
* Fix Stream_URL::parse()Paul Arthur2013-04-131-1/+1
| | | | Also fixes democratic voting.
* Fix democratic playlist displayPaul Arthur2013-04-131-2/+4
|
* Fix date format in CHANGELOGPaul Arthur2013-04-131-1/+1
|
* Fix song downloadsPaul Arthur2013-04-111-0/+1
| | | | | 'download' wasn't in the list of allowed types for Stream_Playlist, so download attempts were processed as M3U playlists.
* Add some extra debug output for transcode_toPaul Arthur2013-04-091-0/+3
|
* GH#4: Tagging artist incorrectlyPaul Arthur2013-04-021-6/+9
| | | | | We should only look up by MBID if we actually have an MBID. Might fix this issue.
* Drop MIGRATIONPaul Arthur2013-03-291-63/+0
| | | | | Should think about making the upgrade section of the README more useful, but this information isn't particularly helpful nowadays.
* INSTALL was outdated and wrong and bad.Paul Arthur2013-03-291-241/+0
|
* Cosmetics: fix markdown in CHANGELOGPaul Arthur2013-03-291-2/+2
|
* Reformat CHANGELOG some more, move old entries outPaul Arthur2013-03-292-2819/+468
|
* Try slightly reformatting CHANGELOGPaul Arthur2013-03-291-0/+2350
|
* Treat Snoopy the same as other external modulesPaul Arthur2013-03-298-136/+793
| | | | | It gets its own directory containing the minimally modified contents of its upstream source tarball.
* Update READMEPaul Arthur2013-03-291-54/+60
|
* Drop nonworking Dba::check_database_exists()Paul Arthur2013-03-292-13/+2
| | | | It didn't work.
* Fix infinite loop in DbaPaul Arthur2013-03-291-1/+1
| | | | Strong and stupid indeed.
* Fix User::count()Paul Arthur2013-03-281-2/+3
|
* Fix Rating::gc()Paul Arthur2013-03-281-1/+1
|
* Don't store plaintext passwordsPaul Arthur2013-03-282-3/+2
| | | | http://dbareactions.tumblr.com/post/41455377237/when-i-see-app-passwords-stored-in-clear-text-in
generated by cgit (git 2.34.1) at 2025-08-13 17:49:03 +0000