Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Drop Dba::escape in vainfo | Paul Arthur | 2013-02-05 | 1 | -3/+3 |
| | |||||
* | Clean up vainfo somewhat | Paul Arthur | 2013-02-05 | 1 | -528/+233 |
| | | | | | | | | | | | | | | Handling of unknown tags was wrong (we should just pass them through and hope for the best, not do some weird-ass id3v2 thing). Add matroska to the list of known tags. Switch the video types to a generic cleanup function and move the several-times-duplicated general information gathering into the general information gathering function where it belongs. Treat the general information as another tag type instead of special-casing it as a complete override through array_merge. Drop the useless iconv stuff (getID3 already translates tags to our requested charset). Rename some functions to more closely match their purpose. Fix some private functions that were marked public. Fix encoding detection, which has been completely broken for a while. | ||||
* | Add fallback title to filename metadata source | Paul Arthur | 2013-02-05 | 1 | -2/+2 |
| | | | | If we didn't parse anything out, set it to the filename. | ||||
* | Cosmetics: death to tabs | Paul Arthur | 2013-01-26 | 1 | -1056/+1056 |
| | | | | | The refactoring I've been doing has reminded me of my strong preference for spaces, and I feel inclined to impose my will on the tree. | ||||
* | Cosmetics: clean up heads in lib/ | Paul Arthur | 2013-01-25 | 1 | -8/+2 |
| | |||||
* | Switch from print_r to json_encode in debug output | Paul Arthur | 2012-11-13 | 1 | -1/+1 |
| | |||||
* | Partial fix for ASF tags | Paul Arthur | 2012-09-06 | 1 | -0/+4 |
| | | | | | | Actually transfer all ASF tags into the asf tag array. I suspect that some things like 'genre' may actually be multivalued, but I don't have any samples to back that up. | ||||
* | Fix disk number parsing for ID3v2 | Paul Arthur | 2012-04-15 | 1 | -1/+1 |
| | | | | | | According to the changelog, getID3 1.7.9 standardised on part_of_a_set as the key for this info (pulled from TPOS or TPA, depending on the minor version of ID3v2); we were looking for 'pos', which is wrong. | ||||
* | Refactor getting MBIDs from ID3 tags | Paul Arthur | 2012-04-12 | 1 | -6/+8 |
| | | | | | Just grab the info from the TXXX bit, instead of relying on a correlation between the raw tags and the cooked ones. | ||||
* | Add support for pulling ratings from id3 tags | Paul Arthur | 2012-04-12 | 1 | -0/+14 |
| | | | | Not used by anything yet, but it might work. | ||||
* | Add support for parsing MBIDs in M4A files | Paul Arthur | 2012-04-11 | 1 | -0/+9 |
| | |||||
* | Don't throw away data that getID3 has deigned to parse | Paul Arthur | 2012-04-11 | 1 | -19/+0 |
| | | | | Fixes M4A tag parsing, probably other things. | ||||
* | Don't run filename patterns through preg_quote twice | Paul Arthur | 2012-03-31 | 1 | -15/+22 |
| | | | | | | | | This would result in extra slashes, e.g. '/\/([0-9]+?)\s\\\-\s(.+?)\..+$/' instead of '/\/([0-9]+?)\s\-\s(.+?)\..+$/' There are some unrelated cosmetic changes as well. | ||||
* | Use '$a ?: $b' instead of '$a ? $a : $b' in vainfo | Paul Arthur | 2012-03-06 | 1 | -95/+31 |
| | | | | Now that we require PHP 5.3, we can use the more compact format. | ||||
* | FS#216 - Cannot add music to catalog with 21 February commit | Paul Arthur | 2012-02-21 | 1 | -2/+2 |
| | | | | The wrong version of this change got pushed, somehow. Fix parse errors. | ||||
* | vainfo: unset disk if totaldiscs is 1 | Paul Arthur | 2012-02-20 | 1 | -6/+10 |
| | | | | | | | | ID3 should only set disk if it's part of a set, but the same is not true of other metadata sources. Also drop no-op attempted cleanup of disk; we've already run intval, so it won't contain a slash. | ||||
* | Drop unnecessary case branch. | Paul Arthur | 2012-02-20 | 1 | -3/+0 |
| | |||||
* | Cosmetics: clean up some cruft in vainfo | Paul Arthur | 2011-11-22 | 1 | -98/+5 |
| | |||||
* | Clean up some PHPDoc crap | Paul Arthur | 2011-04-04 | 1 | -9/+0 |
| | | | | | | Remove misleading, unvetted, or in some cases just plain wrong data. Packages and categories weren't being used correctly. They still aren't. | ||||
* | Add support for autodetecting encoding for broken id3v2 tags | Paul Arthur | 2011-02-21 | 1 | -20/+43 |
| | | | | | Mostly untested. Must be enabled in config, so we won't be breaking people's perfectly valid tags by default. | ||||
* | Partial revert of 678cf4b6aa9d43cf73968a90c49e0a0db2c47fca | Paul Arthur | 2011-02-21 | 1 | -79/+10 |
| | | | | | id3v2 encoding detection was removed for a reason: it breaks valid tags, and id3v2 has proper support for multiple standard multibyte encodings. | ||||
* | Merge gitorious.org:~momo-i/ampache/momo-is-ampache | momo-i | 2011-02-17 | 1 | -0/+1 |
|\ | | | | | | | | | Conflicts: config/ampache.cfg.php.dist | ||||
| * | modified tag broken problems | momo-i | 2011-02-17 | 1 | -1/+1 |
| | | |||||
| * | some id3tags still broken. | momo-i | 2011-02-17 | 1 | -0/+1 |
| | | |||||
* | | modified debug_event | momo-i | 2011-02-17 | 1 | -2/+2 |
|/ | |||||
* | maybe all green! | momo-i | 2011-02-17 | 1 | -10/+16 |
| | |||||
* | remove @todo | momo-i | 2011-02-17 | 1 | -2/+0 |
| | |||||
* | try to get id3v2 tag! | momo-i | 2011-02-16 | 1 | -10/+59 |
| | |||||
* | update getid3 version 1.8.2 -> 2.0.0b6 | momo-i | 2011-02-08 | 1 | -10/+61 |
| | | | | modified vainfo class (not complete) | ||||
* | added @todo id3tag broken | momo-i | 2011-02-04 | 1 | -0/+18 |
| | | | | http://ampache.org/bugs/task/158 this is my task. | ||||
* | Updated a few informations of function. | momo-i | 2011-02-03 | 1 | -7/+93 |
| | |||||
* | Modified header comment for phpdoc | momo-i | 2011-02-03 | 1 | -20/+41 |
| | |||||
* | Break everyone's config by changing metadata gathering. | Paul 'flowerysong' Arthur | 2010-10-06 | 1 | -133/+176 |
| | |||||
* | Some vainfo cleanup. Since id3v2 allows multiple charsets and has a standard ↵ | Paul 'flowerysong' Arthur | 2010-06-22 | 1 | -234/+103 |
| | | | | | | | | way of indicating them, don't try to work around broken id3v2 tags (especially since that breaks valid tags). For id3v1, use a charset detection approach that actually has a chance of working. | ||||
* | Miscellaneous cleanup. | Paul 'flowerysong' Arthur | 2010-06-13 | 1 | -1/+1 |
| | |||||
* | Fix bin/print_tags so it accurately reflects what Ampache will see; it was | Paul 'flowerysong' Arthur | 2010-05-29 | 1 | -6/+5 |
| | | | | stomping on 'file' results for some reason. Also a smidge of cleanup in vainfo. | ||||
* | Cosmetics: remove trailing whitespace | Paul 'flowerysong' Arthur | 2010-03-14 | 1 | -241/+241 |
| | |||||
* | Cosmetics: use tabs for indentation, tweak some indentation/coding style. | Paul 'flowerysong' Arthur | 2010-03-14 | 1 | -5/+5 |
| | |||||
* | Add vim modelines to all php files (Thx ascheel) | Karl 'vollmerk' Vollmer | 2010-03-14 | 1 | -0/+1 |
| | |||||
* | Improved filename pattern matching #575 | Karl 'vollmerk' Vollmer | 2009-12-08 | 1 | -1/+2 |
| | |||||
* | sync from trunk | Karl 'vollmerk' Vollmer | 2009-11-14 | 1 | -4/+37 |
| | |||||
* | Added multiple id3v2 genre to tag patch from quack23 resolves #564 | Karl 'vollmerk' Vollmer | 2009-11-14 | 1 | -8/+42 |
| | |||||
* | sync from 3.5.x branch | Karl 'vollmerk' Vollmer | 2009-08-23 | 1 | -3/+3 |
| | |||||
* | fix empty check for $id3v2['UFID'] | momo-i | 2009-07-03 | 1 | -10/+12 |
| | |||||
* | fixed for PHP 5.3.0 deprecate warnings | momo-i | 2009-07-02 | 1 | -1/+1 |
| | |||||
* | fix title issue and add some more stuff to the boolean list for preferences | Karl 'vollmerk' Vollmer | 2009-06-02 | 1 | -0/+4 |
| | |||||
* | add MBID support Thx flowerysong | Karl 'vollmerk' Vollmer | 2009-06-02 | 1 | -28/+92 |
| | |||||
* | tweaked vainfo to accept 1/2 as a valid disk from TPOS also tweaked id3v2 ↵ | Karl 'vollmerk' Vollmer | 2009-04-09 | 1 | -0/+4 |
| | | | | tags to include TPOS in the comments array | ||||
* | fixed default tag encoding to IDO-8859-1 | momo-i | 2009-04-06 | 1 | -4/+4 |
| | |||||
* | Fixed #424 and applied #423 | Karl 'vollmerk' Vollmer | 2009-03-26 | 1 | -84/+173 |
| |