summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSébastien LIENARD <slix@kerlinux.org>2012-02-20 23:43:12 -0500
committerPaul Arthur <paul.arthur@flowerysong.com>2012-02-20 23:43:12 -0500
commit591a52282451b23a157c707fc5022e1b19d5f674 (patch)
treee878624686ee719a854fb1c0e3e505ae23a4570f
parent073f49c3e876bbc361d0bc8174fc4660208c2e3e (diff)
downloadampache-591a52282451b23a157c707fc5022e1b19d5f674.tar.gz
ampache-591a52282451b23a157c707fc5022e1b19d5f674.tar.bz2
ampache-591a52282451b23a157c707fc5022e1b19d5f674.zip
FS#209 - Google Chrome doesn't show album art when album name contains commas
It seems that Chrome believes that commas end header values (it's probably correct in this belief). Quoting the value should avoid this, and potentially other issues.
-rwxr-xr-xdocs/CHANGELOG2
-rw-r--r--image.php3
2 files changed, 4 insertions, 1 deletions
diff --git a/docs/CHANGELOG b/docs/CHANGELOG
index 79d2dad3..d43b0084 100755
--- a/docs/CHANGELOG
+++ b/docs/CHANGELOG
@@ -4,6 +4,8 @@
--------------------------------------------------------------------------
v.3.6-Alpha2
+ - Quote Content-Disposition header for art, fixes Chrome issue
+ (patch by Sébastien LIENARD)
- Fixed art URL returned via the API (patch by lotan_rm)
- Fixed video searches (reported by mchugh19)
- Fixed Database Upgrade issue that caused catalog user/pass for
diff --git a/image.php b/image.php
index ac6c001f..63523f3c 100644
--- a/image.php
+++ b/image.php
@@ -124,7 +124,8 @@ switch ($_GET['type']) {
header("Cache-Control: no-store, no-cache, must-revalidate");
header("Pragma: no-cache");
header("Content-type: $mime");
- header("Content-Disposition: filename=" . scrub_out($media->name) . "." . $extension);
+ header('Content-Disposition: filename="' . scrub_out($media->name) . '.' .
+ $extension . '"');
echo $source;
break;