Clean up vainfo somewhat

Handling of unknown tags was wrong (we should just pass them through and
hope for the best, not do some weird-ass id3v2 thing).  Add matroska to
the list of known tags. Switch the video types to a generic cleanup
function and move the several-times-duplicated general information
gathering into the general information gathering function where it
belongs.  Treat the general information as another tag type instead of
special-casing it as a complete override through array_merge. Drop the
useless iconv stuff (getID3 already translates tags to our requested
charset). Rename some functions to more closely match their purpose.
Fix some private functions that were marked public. Fix encoding
detection, which has been completely broken for a while.

1 files changed, 4 insertions, 0 deletions

diff --git a/docs/CHANGELOG b/docs/CHANGELOG
index bcaf69d1..c0cec19a 100755
--- a/docs/CHANGELOG
+++ b/docs/CHANGELOG
@@ -4,6 +4,10 @@
 
 --------------------------------------------------------------------------
   v.3.6-FUTURE
+    - Fixed character set detection for ID3v1 tags
+    - Added matroska to the list of known tag types
+    - Made the getID3 metadata source work better with tag types that Ampache
+        doesn't recognise
     - Switched from the deprecated mysql extension to PDO
     - stderr from the transcode command is now logged for debugging
     - Made database updates more robust and verified that a fresh 3.3.3.5 import