| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
According to GH #80 Windows can't handle this.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Should fix GH #74
|
|
|
|
| |
Remove some cruft, update some comments.
|
|
|
|
| |
Seems harmless enough.
|
|
|
|
|
|
|
|
|
| |
Just ask the database for what we want instead of asking for more
results, sifting through them, and hoping that we get enough
qualifying results to fulfill the request.
Also drop Random::album(), since it's duplicate code and it makes more
sense for this to live in Album.
|
| |
|
|
|
|
| |
On second thought, preserving the order might be important.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Can be very efficient with the right input, but probably has
degenerative cases where it increases the size. Worst-case size
increase is one character per ID in the result set, so it shouldn't be
an issue.
String lengths for a large search result that was unstorable before:
serialize: 1991874
json_encode: 756249
cooked: 244
And some with more discontinuity:
serialize: 1772238
json_encode: 674751
cooked: 37950
serialize: 164942
json_encode: 65771
cooked: 25369
|
| |
|
| |
|
|
|
|
|
| |
The API will never request it again, so caching the query just wastes
space.
|
|
|
|
| |
http://msdn.microsoft.com/library/windows/desktop/dd563989%28v=vs.85%29.aspx
|
| |
|
|
|
|
| |
Closes GH #35
|
|
|
|
|
| |
PHPMailer will validate the format of the address, and that's all we
really want.
|
| |
|
|
|
|
|
|
|
|
| |
bea34c42 fixed one use of is_readable, but Windows users encountering
this issue would still be affected in other cases. This commit fixes
all of the important is_readable calls within Ampache; I'm not going
to hack this into external modules, so if they're broken people will
have to live with it.
|
| |
|
|
|
|
|
| |
The structure of the temporary $ratings array changed a while ago, but
we were still trying to pull the global rating from the old structure.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://php.net/manual/en/function.session-set-save-handler.php:
When using objects as session save handlers, it is important
to register the shutdown function with PHP to avoid unexpected
side-effects from the way PHP internally destroys objects on
shutdown and may prevent the write and close from being called.
Typically you should register 'session_write_close' using the
register_shutdown_function() function.
We're not using objects as session save handlers, but some people
(notably, Synology users) seem to be encountering a similar issue
related to the timing of object destruction. Closing the session
earlier in the shutdown process is a perfectly sane thing to do, so
let's do it.
|
|
|
|
|
| |
Will hopefully return more useful information during installation, which
is the only place it's actually used and useful.
|
| |
|
|
|
|
|
|
| |
Splitting some things off to ampache-catalog doesn't really make sense
to me and makes it harder to see the entire process during catalog
operations.
|
|
|
|
| |
Return false and unset the id if the song isn't in the database.
|
|
|
|
|
|
| |
The join was incorrect, sometimes resulting in loss of ratings.
Fixes GH #22
|
|
|
|
| |
Fixes GH#23
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
InnoDB's performance is unacceptable out of the box, and there's no
clean way to batch these insertions into transactions, and stuff.
Benchmarks for 1000 inserts:
InnoDB: 54.826
MyISAM: 0.091
InnoDB transaction: 0.159
Fixes GH #14
|
| |
|
|
|
|
|
|
|
|
|
| |
Include the correct type parameter in the URL and rename the random
type parameter to random_type.
Remove unused parameters from the function call.
Should fix issue #11
|
|
|
|
| |
Also fixes democratic voting.
|
| |
|
|
|
|
|
| |
'download' wasn't in the list of allowed types for Stream_Playlist, so
download attempts were processed as M3U playlists.
|
|
|
|
|
| |
We should only look up by MBID if we actually have an MBID. Might fix
this issue.
|
|
|
|
| |
It didn't work.
|
|
|
|
| |
Strong and stupid indeed.
|
| |
|
| |
|
|
|
|
| |
http://dbareactions.tumblr.com/post/41455377237/when-i-see-app-passwords-stored-in-clear-text-in
|